Skip to content

Move bwcVersions extension property to BuildParams (back port) #56382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

breskeby
Copy link
Contributor

@breskeby breskeby commented May 7, 2020

This is a backport for

#56206
#56332

breskeby and others added 2 commits May 7, 2020 21:28
- resolved in GlobalBuildInfoPlugin
- propagate exception if version file cannot be resolved
- add null check when setting bwcVersions
I think we missed this spot in elastic#56206 breaking the task and thus Gradle imports into Idea.
@breskeby breskeby added :Delivery/Build Build or test infrastructure backport labels May 7, 2020
@breskeby breskeby self-assigned this May 7, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (:Core/Infra/Build)

@elasticmachine elasticmachine added the Team:Core/Infra Meta label for core/infra team label May 7, 2020
@breskeby
Copy link
Contributor Author

@elasticmachine test this please

@breskeby breskeby merged commit 75e64f2 into elastic:7.8 May 11, 2020
@breskeby breskeby deleted the fix/build/move-bwcVersions-to-build-params-7-8 branch May 11, 2020 10:56
@mark-vieira mark-vieira added Team:Delivery Meta label for Delivery team and removed Team:Core/Infra Meta label for core/infra team labels Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport :Delivery/Build Build or test infrastructure Team:Delivery Meta label for Delivery team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants