Skip to content

SQL: Fix range of version number generation in version test #56849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2020

Conversation

bpintea
Copy link
Contributor

@bpintea bpintea commented May 15, 2020

The version number component can't equal or exceed the revision
multiplier.
This fixes the VersionTests unit test.

The version number componenent can't equal or exceed the revision
multiplier.
This fixes a the VersionTests unit test.
@bpintea bpintea added >bug >test Issues or PRs that are addressing/adding tests :Analytics/SQL SQL querying labels May 15, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-ql (:Query Languages/SQL)

@elasticmachine elasticmachine added the Team:QL (Deprecated) Meta label for query languages team label May 15, 2020
@bpintea bpintea added >non-issue and removed :Analytics/SQL SQL querying Team:QL (Deprecated) Meta label for query languages team labels May 16, 2020
@bpintea
Copy link
Contributor Author

bpintea commented May 16, 2020

@elasticmachine run elasticsearch-ci/2

@bpintea bpintea marked this pull request as ready for review May 16, 2020 06:57
@bpintea bpintea merged commit 7d2331a into elastic:master May 16, 2020
@bpintea bpintea deleted the fix/sql_version_tests_fix_limit branch May 16, 2020 06:57
bpintea added a commit that referenced this pull request May 16, 2020
The version number componenent can't equal or exceed the revision
multiplier.
This fixes a the VersionTests unit test.

(cherry picked from commit 7d2331a)
bpintea added a commit that referenced this pull request May 16, 2020
The version number componenent can't equal or exceed the revision
multiplier.
This fixes a the VersionTests unit test.

(cherry picked from commit 7d2331a)
bpintea added a commit that referenced this pull request May 16, 2020
The version number componenent can't equal or exceed the revision
multiplier.
This fixes a the VersionTests unit test.

(cherry picked from commit 7d2331a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug >non-issue >test Issues or PRs that are addressing/adding tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants