Skip to content

[7.8] Do not report negative values for swap sizes #57352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

danhermann
Copy link
Contributor

This applies the same fixes for negative memory values in #42725 and #56435 to swap values.

Fixes #57312

Backport of #57317

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (:Core/Features/Monitoring)

@elasticmachine elasticmachine added the Team:Data Management Meta label for data/management team label May 29, 2020
@danhermann danhermann merged commit 8e4d07c into elastic:7.8 May 29, 2020
@danhermann danhermann deleted the backport_78_57317_negative_swap_values branch May 29, 2020 13:02
@matschaffer
Copy link
Contributor

Are there other situations we might see "[instance-0000000011] OS reported a negative free swap space size [-114688]" on 7.8.0? We have a cluster here with it in the logs

@danhermann
Copy link
Contributor Author

@matschaffer, the "fix" for this issue was when the OS reports a negative value, serialize a zero instead for the unsigned stats value rather than throwing an exception and possibly blocking certain operations. In other words, the OS may still report negative values and we still log warnings when that happens, but we don't crash when serializing the stats. There is a bug filed upstream on the JVM for the negative values but we have no further information on if or when that will be addressed.

@matschaffer
Copy link
Contributor

Thanks! that explains why we're still seeing the logs then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants