Add RequestConfig support to RequestOptions #57972
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jbaiera hi，jbaiera, can you help to review this PR. |
matriv
added
the
:Clients/Java Low Level REST Client
|
Pinging @elastic/es-core-features (:Core/Features/Java Low Level REST Client) |
elasticmachine
added
the
Team:Data Management
|
@jasontedor hi，jasontedor, can you help to review this PR. |
|
@jakelandis Can you help find someone to review this PR? |
jbaiera
reviewed
Jun 25, 2020
client/rest/src/test/java/org/elasticsearch/client/documentation/RestClientDocumentation.java
Outdated
Show resolved
Hide resolved
|
@elasticmachine ok to test |
|
@elasticmachine update branch |
jbaiera
pushed a commit
to jbaiera/elasticsearch
that referenced
this pull request
Jul 9, 2020
Different kinds of requests may need different request options from the client default. Users can optionally set RequestConfig on a single request's RequestOptions to override the default. Without this, socketTimeout can only set at RestClient initialization.
jbaiera
added a commit
that referenced
this pull request
Jul 14, 2020
Different kinds of requests may need different request options from the client default. Users can optionally set RequestConfig on a single request's RequestOptions to override the default. Without this, socketTimeout can only set at RestClient initialization. Co-authored-by: weizijun <[email protected]>
pugnascotia
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As RequestOptions add RequestConfig, users can set some request config per request, e.g socketTimeout.
Without RequestConfig, socketTimeout can only set in RestClient init.
As different kind of request maybe have different request options, users can set RequestConfig Optional.