Skip to content

Correct default formatting of binary fields #58338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 18, 2020
Merged

Correct default formatting of binary fields #58338

merged 1 commit into from
Jun 18, 2020

Conversation

romseygeek
Copy link
Contributor

This was picked up in the backport of #57666 but missed in the original commit
on master, leading to failures such as #58282

@romseygeek romseygeek added >non-issue :Search Foundations/Mapping Index mappings, including merging and defining field types v8.0.0 labels Jun 18, 2020
@romseygeek romseygeek requested a review from nik9000 June 18, 2020 16:00
@romseygeek romseygeek self-assigned this Jun 18, 2020
nik9000
nik9000 approved these changes Jun 18, 2020
View reviewed changes
Copy link
Member

@nik9000 nik9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@romseygeek romseygeek merged commit 409306e into elastic:master Jun 18, 2020
@jimczi jimczi mentioned this pull request Jun 24, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nik9000 nik9000 nik9000 approved these changes

Assignees

@romseygeek romseygeek

Labels
>non-issue :Search Foundations/Mapping Index mappings, including merging and defining field types v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@romseygeek @nik9000 @jakelandis