-
Notifications
You must be signed in to change notification settings - Fork 25.2k
[DOCS] Add data streams to bulk, delete, and index API docs #58340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Add data streams to bulk, delete, and index API docs #58340
Conversation
Updates existing docs for the bulk, delete and index APIs to make them aware of data streams.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor and one more significant comment below:
docs/reference/docs/bulk.asciidoc
Outdated
Name of the index associated with the operation. If the operation targeted a | ||
data stream, this is the associated backing index. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor: I wonder if it would be more clear to say something along the lines of "the backing index into which the document was written" instead of "associated backing index" since a data stream may have many associated backing indices.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. I used this wording here and a modified version for failed operations.
docs/reference/docs/delete.asciidoc
Outdated
@@ -4,18 +4,19 @@ | |||
<titleabbrev>Delete</titleabbrev> | |||
++++ | |||
|
|||
Removes a JSON document from the specified index. | |||
Removes a JSON document from a specified data stream or index. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We disallow deletes directly on a data stream because it would require searching every backing index for the specified ID. If a document is to be deleted from a data stream, the relevant backing index must be targeted directly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:doh: Thanks for catching this. I think I got overzealous.
Fixed up here: https://github.com/elastic/elasticsearch/pull/58340/files#diff-907ef82eb2dfb22151e4312359f5aee4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks, @jrodewig!
Updates existing docs for the bulk, delete and index APIs to make them
aware of data streams.