Skip to content

[7.x] Add test for component templates updated after cluster restart (#58883) #58914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 2, 2020

Conversation

dakrone
Copy link
Member

@dakrone dakrone commented Jul 2, 2020

Backports the following commits to 7.x:

…ic#58883)

This commit adds an integration test that component templates used to form a composite template can
still be updated after a cluster restart.

In elastic#58643 an issue arose where mappings were causing problems because of the way we unwrap `_doc` in
template mappings. This was also related to the mappings being merged manually rather than using the
`MapperService` to do the merging. elastic#58643 was fixed in 7.9 and master with the elastic#58521 change, since
mappings now are read and digested by the actual mapper service.

This test passes for 7.x and master, and I intend to open a separate PR including this test for
7.8.1 along with a bug fix for elastic#58643. This test is to ensure we don't have any regression in the
future.
@dakrone dakrone added backport :Data Management/Indices APIs APIs to create and manage indices and templates >test Issues or PRs that are addressing/adding tests v7.9.0 labels Jul 2, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (:Core/Features/Indices APIs)

@elasticmachine elasticmachine added the Team:Data Management Meta label for data/management team label Jul 2, 2020
@dakrone dakrone merged commit e32623e into elastic:7.x Jul 2, 2020
@dakrone dakrone deleted the backport/7.x/pr-58883 branch July 2, 2020 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport :Data Management/Indices APIs APIs to create and manage indices and templates Team:Data Management Meta label for data/management team >test Issues or PRs that are addressing/adding tests v7.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants