-
Notifications
You must be signed in to change notification settings - Fork 25.2k
[7.x] Add rolling upgrade tests for component and composable templates (#58867) #58969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…stic#58867) This adds rolling upgrade tests that component and composable templates can be read from older versions of the cluster. Relates to elastic#58643
Pinging @elastic/es-core-features (:Core/Features/Indices APIs) |
@elasticmachine update branch |
@elasticmachine update branch |
…amlTestSuiteIT` and use that to skip tests based on versions.
@dakrone Would you like to take a look at this PR? I made two small modifications (see last 2 commits, which fixed bwc test failures against clusters that upgrade from 6.8.x), but I think this change can be back ported to 7.x now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Martijn, I left one comment but otherwise I think this looks good, do you want to add the javadoc and then I merge it, or do you want to just go ahead and merge it yourself?
@@ -157,6 +157,10 @@ public void initAndResetContext() throws Exception { | |||
restTestExecutionContext.clear(); | |||
} | |||
|
|||
protected Version overwriteEsVersion(Version esVersionFromApi) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add some javadoc to this method since it's going into the test framework and can be used elsewhere?
@elasticmachine update branch |
@elasticmachine update branch |
Backports the following commits to 7.x: