Skip to content

[7.x] Add rolling upgrade tests for component and composable templates (#58867) #58969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 4, 2021

Conversation

dakrone
Copy link
Member

@dakrone dakrone commented Jul 2, 2020

Backports the following commits to 7.x:

…stic#58867)

This adds rolling upgrade tests that component and composable templates can be read from older
versions of the cluster.

Relates to elastic#58643
@dakrone dakrone added backport :Data Management/Indices APIs APIs to create and manage indices and templates v7.9.0 labels Jul 2, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (:Core/Features/Indices APIs)

@elasticmachine elasticmachine added the Team:Data Management Meta label for data/management team label Jul 2, 2020
@dakrone
Copy link
Member Author

dakrone commented Jul 7, 2020

@elasticmachine update branch

@dakrone
Copy link
Member Author

dakrone commented Oct 1, 2020

@elasticmachine update branch

@dakrone dakrone closed this Jan 14, 2021
@martijnvg martijnvg removed the v7.9.0 label Apr 20, 2021
@martijnvg martijnvg reopened this Apr 20, 2021
@martijnvg
Copy link
Member

@dakrone Would you like to take a look at this PR? I made two small modifications (see last 2 commits, which fixed bwc test failures against clusters that upgrade from 6.8.x), but I think this change can be back ported to 7.x now.

Copy link
Member Author

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Martijn, I left one comment but otherwise I think this looks good, do you want to add the javadoc and then I merge it, or do you want to just go ahead and merge it yourself?

@@ -157,6 +157,10 @@ public void initAndResetContext() throws Exception {
restTestExecutionContext.clear();
}

protected Version overwriteEsVersion(Version esVersionFromApi) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add some javadoc to this method since it's going into the test framework and can be used elsewhere?

@martijnvg
Copy link
Member

@elasticmachine update branch

@martijnvg
Copy link
Member

@elasticmachine update branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport :Data Management/Indices APIs APIs to create and manage indices and templates Team:Data Management Meta label for data/management team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants