Fix broken links to aggregation javadoc #59083
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/es-docs (>docs) |
davidkyle
force-pushed
the
pipeline-agg-broken-links
branch
from
a1c2265 to
78ad83b
Compare
szabosteve
reviewed
Jul 9, 2020
There was a problem hiding this comment.
Thank you for making this fix @davidkyle! I've found two broken links. I left a suggestion to fix one of them, but I haven't found the appropriate URL for the other.
Co-authored-by: István Zoltán Szabó <[email protected]>
Co-authored-by: István Zoltán Szabó <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The links from the Java High Level Rest Client to the aggregations java docs are broken probably due to a refactoring of the code.
The diff looks horrendous but the change is mostly removing one element of the path e.g.
/metrics/avg/AvgAggregationBuilder.htmlbecomes/metrics/AvgAggregationBuilder.htmlPreview: https://elasticsearch_59083.docs-preview.app.elstc.co/guide/en/elasticsearch/client/java-rest/master/java-rest-high-aggregation-builders.html