Fix SLMSnapshotBlockingIntegTests.testSnapshotInProgress #59218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Waiting `INIT` here is dead code in newer versions that don't use `INIT` any longer and leads to nothing being written to the repository in older versions if the snapshot is cancelled at the `INIT` step which then breaks repo consistency checks. Since we have other tests ensuring that snapshot abort works properly we can just remove the wait for `INIT` here and backport this down to 7.8 to fix tests. fixes elastic#59140
original-brownbear
added
>test
|
Pinging @elastic/es-core-features (:Core/Features/ILM+SLM) |
This was referenced Jul 8, 2020
|
Thanks Lee! |
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Jul 8, 2020
Waiting `INIT` here is dead code in newer versions that don't use `INIT` any longer and leads to nothing being written to the repository in older versions if the snapshot is cancelled at the `INIT` step which then breaks repo consistency checks. Since we have other tests ensuring that snapshot abort works properly we can just remove the wait for `INIT` here and backport this down to 7.8 to fix tests. relates elastic#59140
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Jul 8, 2020
Waiting `INIT` here is dead code in newer versions that don't use `INIT` any longer and leads to nothing being written to the repository in older versions if the snapshot is cancelled at the `INIT` step which then breaks repo consistency checks. Since we have other tests ensuring that snapshot abort works properly we can just remove the wait for `INIT` here and backport this down to 7.8 to fix tests. relates elastic#59140
original-brownbear
added a commit
that referenced
this pull request
Jul 8, 2020
…9239) Waiting `INIT` here is dead code in newer versions that don't use `INIT` any longer and leads to nothing being written to the repository in older versions if the snapshot is cancelled at the `INIT` step which then breaks repo consistency checks. Since we have other tests ensuring that snapshot abort works properly we can just remove the wait for `INIT` here and backport this down to 7.8 to fix tests. relates #59140
original-brownbear
added a commit
that referenced
this pull request
Jul 8, 2020
…9240) Waiting `INIT` here is dead code in newer versions that don't use `INIT` any longer and leads to nothing being written to the repository in older versions if the snapshot is cancelled at the `INIT` step which then breaks repo consistency checks. Since we have other tests ensuring that snapshot abort works properly we can just remove the wait for `INIT` here and backport this down to 7.8 to fix tests. relates #59140
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Waiting
INIThere is dead code in newer versions that don't useINITany longer and leads to nothing being written to the repository in older versions
if the snapshot is cancelled at the
INITstep which then breaks repo consistencychecks.
Since we have other tests ensuring that snapshot abort works properly we can just remove
the wait for
INIThere and backport this down to 7.8 to fix tests.relates #59140 (fixed one out of the two possible failure modes in there)