Skip to content

Remove remaining deprecated api usages #59231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

breskeby
Copy link
Contributor

@breskeby breskeby commented Jul 8, 2020

  • Fix deprecated non annotated input property in LazyPropertyList
  • Fix deprecated usage of AbstractArchiveTask.version
  • Fix duplicate paths copying in processTestResources by removing duplicate files from codebase

Files in x-pack/plugin/security/src/test/resources/org/elasticsearch/xpack/security/transport/ssl/certs/simple/
are duplicates of x-pack/core/src/test/resources/org/elasticsearch/xpack/security/transport/ssl/certs/simple/ and both are used to be copied when running processTestResources in x-pack/plugin/security. This PR removes these duplicates from the codebase.

Related to #57920

breskeby added 2 commits July 8, 2020 16:16
- fix deprecated non annotated input property in LazyPropertyList
- fix deprecated usage of AbstractArchiveTask.version
@breskeby breskeby self-assigned this Jul 8, 2020
@breskeby breskeby added :Delivery/Build Build or test infrastructure Team:Core/Infra Meta label for core/infra team v7.8.2 v7.9.0 v8.0.0 labels Jul 8, 2020
@breskeby breskeby marked this pull request as ready for review July 9, 2020 08:44
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (:Core/Infra/Build)

@breskeby breskeby requested a review from mark-vieira July 10, 2020 08:58
Copy link
Contributor

@mark-vieira mark-vieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I assume all the security stuff was duplicated from the core x-pack project so that's why we've remoted it?

@breskeby breskeby merged commit 8d457a2 into elastic:master Jul 14, 2020
@breskeby breskeby deleted the remove-duplicate-test-resources-causing-deprecation-warnings branch July 14, 2020 07:11
breskeby added a commit to breskeby/elasticsearch that referenced this pull request Jul 14, 2020
- Fix duplicate path deprecation by removing duplicate test resources
- fix deprecated non annotated input property in LazyPropertyList
- fix deprecated usage of AbstractArchiveTask.version
- Resolve correct test resources
breskeby added a commit that referenced this pull request Jul 14, 2020
- Fix duplicate path deprecation by removing duplicate test resources
- fix deprecated non annotated input property in LazyPropertyList
- fix deprecated usage of AbstractArchiveTask.version
- Resolve correct test resources
breskeby added a commit to breskeby/elasticsearch that referenced this pull request Jul 14, 2020
- Fix duplicate path deprecation by removing duplicate test resources
- fix deprecated non annotated input property in LazyPropertyList
- fix deprecated usage of AbstractArchiveTask.version
- Resolve correct test resources
breskeby added a commit that referenced this pull request Jul 14, 2020
- Fix duplicate path deprecation by removing duplicate test resources
- Fix deprecated non annotated input property in LazyPropertyList
- Fix deprecated usage of AbstractArchiveTask.version
- Resolve correct test resources
@mark-vieira mark-vieira added Team:Delivery Meta label for Delivery team and removed Team:Core/Infra Meta label for core/infra team labels Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Delivery/Build Build or test infrastructure Team:Delivery Meta label for Delivery team v7.8.2 v7.9.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants