Default gateway.auto_import_dangling_indices to false #59302
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pugnascotia
added
>enhancement
>breaking
:Distributed Indexing/Distributed
|
Pinging @elastic/es-distributed (:Distributed/Distributed) |
elasticmachine
added
the
Team:Distributed (Obsolete)
|
@elasticmachine run elasticsearch-ci/oss-distro-docs |
lockewritesdocs
approved these changes
Jul 13, 2020
DaveCTurner
requested changes
Jul 13, 2020
That's a good call @DaveCTurner 👍 Thanks for pointing out that change. |
|
Thanks @DaveCTurner. I didn't feel entirely comfortable with completely removing the content from the release notes, so I abbreviated it and pointed it to the migration notes. |
DaveCTurner
reviewed
Jul 14, 2020
| === Settings changes | ||
|
|
||
| [[deprecate_auto_import_dangling_indices]] | ||
| .Automatically importing dangling indices is deprecated. |
There was a problem hiding this comment.
Suggest this, since deprecating something isn't itself a breaking change:
Suggested change
| .Automatically importing dangling indices is deprecated. | |
| .Automatically importing dangling indices is disabled by default. |
| [%collapsible] | ||
| ==== | ||
| *Details* + | ||
| <<dangling-indices,Dangling indices>> will no longer be imported |
There was a problem hiding this comment.
I think it'd help to move some things around here: IMO the Details section describes the change and the Impact tells the user what to do about it. How about this:
diff --git a/docs/reference/migration/migrate_7_9.asciidoc b/docs/reference/migration/migrate_7_9.asciidoc
index e60c4f3588d..acfd11fc38b 100644
--- a/docs/reference/migration/migrate_7_9.asciidoc
+++ b/docs/reference/migration/migrate_7_9.asciidoc
@@ -80,16 +80,18 @@ context. For example, for the `processor_conditional` context, use
[%collapsible]
====
*Details* +
-<<dangling-indices,Dangling indices>> will no longer be imported
-automatically by default. A new
-<<dangling-indices-api,Dangling indices API>> is now available, which you
-can use to list, import, or delete. Because importing dangling indices
-automatically into the cluster is unsafe, use the dedicated API instead.
+Automatically importing <<dangling-indices,dangling indices>> into the cluster
+is unsafe and is now disabled by default. This feature will be removed entirely
+in {es} 8.0.0.
*Impact* +
-Automatically importing dangling indices is now deprecated, disabled by
-default, and will be removed in (es) 8.0. If you need to re-enable
-auto-imports, set `gateway.auto_import_dangling_indices` to `true`.
+Use the <<dangling-indices-api,Dangling indices API>> to list, delete or import
+any dangling indices manually.
++
+Alternatively you can enable automatic imports of dangling indices, recovering
+the unsafe behaviour of earlier versions, by setting
+`gateway.auto_import_dangling_indices` to `true`. This setting is deprecated
+and will be removed in {es} 8.0.0. We do not recommend using this setting.
====
//end::notable-breaking-changes[]|
|
||
| Dangling indices:: | ||
| * Automatically importing dangling indices is now deprecated, disabled by | ||
| default, and will be removed in (es) 8.0. See the |
There was a problem hiding this comment.
I think you meant this:
Suggested change
| default, and will be removed in (es) 8.0. See the | |
| default, and will be removed in {es} 8.0. See the |
pugnascotia
force-pushed
the
auto-dangling-index-import-default-off-7x
branch
from
c4f08d1 to
af7a176
Compare
Part of elastic#48366. Now that there is a dedicated API for dangling indices, the auto-import behaviour can default to off.
Co-authored-by: Adam Locke <[email protected]>
Move most of the breaking changes regarding dangling indices in the 7.9 release notes to the 7.9 migration doc. Abbreviate the release ntoes content and point to the migration notes instead.
pugnascotia
force-pushed
the
auto-dangling-index-import-default-off-7x
branch
from
af7a176 to
6eb2c5f
Compare
|
Cherry-picked to |
pugnascotia
added a commit
that referenced
this pull request
Jul 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #58898.
Part of #48366. Now that there is a dedicated API for dangling indices, the auto-import behaviour can default to off. Also add a note to the breaking changes for 7.9.0.