Adds write_index_only option to put mapping API #59396
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danhermann
added
>non-issue
v8.0.0
:Data Management/Data streams
|
Pinging @elastic/es-core-features (:Core/Features/Data streams) |
elasticmachine
added
the
Team:Data Management
martijnvg
approved these changes
Jul 13, 2020
| @@ -67,6 +67,7 @@ public RestChannelConsumer prepareRequest(final RestRequest request, final NodeC | |||
| putMappingRequest.timeout(request.paramAsTime("timeout", putMappingRequest.timeout())); | |||
| putMappingRequest.masterNodeTimeout(request.paramAsTime("master_timeout", putMappingRequest.masterNodeTimeout())); | |||
| putMappingRequest.indicesOptions(IndicesOptions.fromRequest(request, putMappingRequest.indicesOptions())); | |||
| putMappingRequest.writeIndexOnly(request.paramAsBoolean("write_index_only", false)); | |||
There was a problem hiding this comment.
I think we need to add this parameter to rest spec as well?
|
|
||
| ClusterState cs = DeleteDataStreamRequestTests.getClusterStateWithDataStreams(dsMetadata, List.of("index1", "index2", "index3")); | ||
| final ClusterState cs2 = addAliases(cs, List.of( | ||
| tuple("alias1", List.of(tuple("index1", false), tuple("index2", true))), |
There was a problem hiding this comment.
I think this test fails? since index2 is write index?
danhermann
added a commit
to danhermann/elasticsearch
that referenced
this pull request
Jul 14, 2020
This was referenced Jul 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
write_index_onlyoption to the put mapping API that defaults tofalse. Whenfalse, the put mapping API applies any mapping changes to all the indices to which any specified data streams and aliases expand. Whentrue, the put mapping API will apply the changes only to the write index for any specified data streams and aliases.Relates to #53100