Skip to content

ScriptLongFieldData to extend LeafLongFieldData #59884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 21, 2020
Merged

ScriptLongFieldData to extend LeafLongFieldData #59884

merged 2 commits into from
Jul 21, 2020

Conversation

javanna
Copy link
Member

@javanna javanna commented Jul 20, 2020

Relates to #59332

@javanna javanna added the :Search/Search Search-related issues that do not fall into other categories label Jul 20, 2020
@javanna javanna requested a review from nik9000 July 20, 2020 14:02
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (:Search/Search)

@elasticmachine elasticmachine added the Team:Search Meta label for search team label Jul 20, 2020
@javanna javanna mentioned this pull request Jul 20, 2020
Closed
30 tasks
nik9000
nik9000 approved these changes Jul 20, 2020
View reviewed changes
Copy link
Member

@nik9000 nik9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

...ields/src/main/java/org/elasticsearch/xpack/runtimefields/fielddata/ScriptLongFieldData.java
public static class ScriptLongLeafFieldData implements LeafNumericFieldData {
private final ScriptLongDocValues scriptBinaryDocValues;
public static class ScriptLongLeafFieldData extends LeafLongFieldData {
private final ScriptLongDocValues scriptLongDocValues;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@javanna javanna merged commit a0ef1ea into elastic:feature/runtime_fields Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nik9000 nik9000 nik9000 approved these changes

Assignees
No one assigned
Labels
:Search/Search Search-related issues that do not fall into other categories Team:Search Meta label for search team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@javanna @elasticmachine @nik9000