-
Notifications
You must be signed in to change notification settings - Fork 25.2k
Introduce 64-bit unsigned long field type #60050
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mayya-sharipova
merged 18 commits into
elastic:master
from
mayya-sharipova:unsigned64bits_integer
Sep 23, 2020
Merged
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
dffd748
Introduce 64-bit unsigned long field type
mayya-sharipova 7eb2d4a
Address feedback
mayya-sharipova 612b7da
Merge remote-tracking branch 'upstream/master' into unsigned64bits_in…
mayya-sharipova ada3422
Modifications after master merge
mayya-sharipova 7551cd6
Merge remote-tracking branch 'upstream/master' into unsigned64bits_in…
mayya-sharipova e903940
Rename methods
mayya-sharipova 9e057c0
Address Jim's feedback
mayya-sharipova ab54a23
Include unsigned_long docs into numeric type
mayya-sharipova 4de3bd0
Merge remote-tracking branch 'upstream/master' into unsigned64bits_in…
mayya-sharipova 2b567c9
Convert UnsignedLongFieldMapper to parametrized
mayya-sharipova 07470b5
Small edits in documentation
mayya-sharipova 17912bc
Address Julie's comment on documentation
mayya-sharipova b2eef4c
Add check that unsigned_long field type can't be sorted with other types
mayya-sharipova b315a0f
Merge remote-tracking branch 'upstream/master' into unsigned64bits_in…
mayya-sharipova 7652e66
Fix build and test failures
mayya-sharipova 0508e70
Merge remote-tracking branch 'upstream/master' into unsigned64bits_in…
mayya-sharipova 24cbe55
Rename the method for validating consistency of merge formats
mayya-sharipova cca6b30
Change unsigned_long mapper based on recent master changes
mayya-sharipova File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,147 @@ | ||
[role="xpack"] | ||
[testenv="basic"] | ||
|
||
[[unsigned-long]] | ||
=== Unsigned long data type | ||
++++ | ||
<titleabbrev>Unsigned long</titleabbrev> | ||
++++ | ||
|
||
Unsigned long is a numeric field type that represents an unsigned 64-bit | ||
integer with a minimum value of 0 and a maximum value of +2^64^-1+ | ||
(from 0 to 18446744073709551615). | ||
mayya-sharipova marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
At index-time, an indexed value is converted to the singed long range: | ||
mayya-sharipova marked this conversation as resolved.
Show resolved
Hide resolved
|
||
[- 9223372036854775808, 9223372036854775807] by subtracting +2^63^+ from it | ||
and stored as a singed long taking 8 bytes. | ||
At query-time, the same conversion is done on query terms. | ||
mayya-sharipova marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
[source,console] | ||
-------------------------------------------------- | ||
PUT my_index | ||
{ | ||
"mappings": { | ||
"properties": { | ||
"my_counter": { | ||
"type": "unsigned_long" | ||
} | ||
} | ||
} | ||
} | ||
-------------------------------------------------- | ||
|
||
Unsigned long can be indexed in a numeric or string form, | ||
representing integer values in the range [0, 18446744073709551615]. | ||
They can't have a decimal part. | ||
|
||
[source,console] | ||
-------------------------------- | ||
POST /my_index/_bulk?refresh | ||
{"index":{"_id":1}} | ||
{"my_counter": 0} | ||
{"index":{"_id":2}} | ||
{"my_counter": 9223372036854775808} | ||
{"index":{"_id":3}} | ||
{"my_counter": 18446744073709551614} | ||
{"index":{"_id":4}} | ||
{"my_counter": 18446744073709551615} | ||
-------------------------------- | ||
//TEST[continued] | ||
|
||
Term queries accept any numbers in a numeric or string form. | ||
|
||
[source,console] | ||
-------------------------------- | ||
GET /my_index/_search | ||
{ | ||
"query": { | ||
"term" : { | ||
"my_counter" : 18446744073709551615 | ||
} | ||
} | ||
} | ||
-------------------------------- | ||
//TEST[continued] | ||
|
||
Range queries can contain ranges with decimal parts. | ||
mayya-sharipova marked this conversation as resolved.
Show resolved
Hide resolved
|
||
It is recommended to pass ranges as strings to ensure they are parsed | ||
without any loss of precision. | ||
|
||
[source,console] | ||
-------------------------------- | ||
GET /my_index/_search | ||
{ | ||
"query": { | ||
"range" : { | ||
"my_counter" : { | ||
"gte" : "9223372036854775808.5", | ||
"lte" : "18446744073709551615" | ||
} | ||
} | ||
} | ||
} | ||
-------------------------------- | ||
//TEST[continued] | ||
|
||
WARNING: Unlike term and range queries, sorting and aggregations on | ||
unsigned_long data may return imprecise results. For sorting and aggregations | ||
double representation of unsigned longs is used, which means that long values | ||
are first converted to double values. During this conversion, | ||
for long values greater than +2^53^+ there could be some loss of | ||
precision for the least significant digits. Long values less than +2^53^+ | ||
are converted accurately. | ||
|
||
[source,console] | ||
-------------------------------- | ||
GET /my_index/_search | ||
{ | ||
"query": { | ||
"match_all" : {} | ||
}, | ||
"sort" : {"my_counter" : "desc"} <1> | ||
} | ||
-------------------------------- | ||
//TEST[continued] | ||
<1> As both document values: "18446744073709551614" and "18446744073709551615" | ||
are converted to the same double value: "1.8446744073709552E19", this | ||
descending sort may return imprecise results, as the document with a lower | ||
value of "18446744073709551614" may come before the document | ||
with a higher value of "18446744073709551615". | ||
|
||
[[unsigned-long-params]] | ||
==== Parameters for unsigned long fields | ||
|
||
The following parameters are accepted: | ||
|
||
[horizontal] | ||
|
||
<<doc-values,`doc_values`>>:: | ||
|
||
Should the field be stored on disk in a column-stride fashion, so that it | ||
can later be used for sorting, aggregations, or scripting? Accepts `true` | ||
(default) or `false`. | ||
|
||
<<ignore-malformed,`ignore_malformed`>>:: | ||
|
||
If `true`, malformed numbers are ignored. If `false` (default), malformed | ||
numbers throw an exception and reject the whole document. | ||
|
||
<<mapping-index,`index`>>:: | ||
|
||
Should the field be searchable? Accepts `true` (default) and `false`. | ||
|
||
<<null-value,`null_value`>>:: | ||
|
||
Accepts a numeric value of the same `type` as the field which is | ||
substituted for any explicit `null` values. Defaults to `null`, which | ||
means the field is treated as missing. | ||
|
||
<<mapping-store,`store`>>:: | ||
|
||
Whether the field value should be stored and retrievable separately from | ||
the <<mapping-source-field,`_source`>> field. Accepts `true` or `false` | ||
(default). | ||
|
||
<<mapping-field-meta,`meta`>>:: | ||
|
||
Metadata about the field. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License; | ||
* you may not use this file except in compliance with the Elastic License. | ||
*/ | ||
|
||
evaluationDependsOn(xpackModule('core')) | ||
|
||
apply plugin: 'elasticsearch.esplugin' | ||
|
||
esplugin { | ||
name 'unsigned-long' | ||
description 'Module for the unsigned long field type' | ||
classname 'org.elasticsearch.xpack.unsignedlong.UnsignedLongMapperPlugin' | ||
extendedPlugins = ['x-pack-core'] | ||
} | ||
archivesBaseName = 'x-pack-unsigned-long' | ||
|
||
dependencies { | ||
compileOnly project(path: xpackModule('core'), configuration: 'default') | ||
testImplementation project(path: xpackModule('core'), configuration: 'testArtifacts') | ||
} | ||
|
||
integTest.enabled = false |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.