[Transform] disable optimizations when using scripts in group_by #60724
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/ml-core (:ml/Transform) |
hendrikmuhs
pushed a commit
that referenced
this pull request
Aug 5, 2020
) disable optimizations when using scripts in group_by, when scripts using scripts we can not predict the outcome and we have no query counterpart. Other optimizations for other group_by's are not affected. fixes #57332
hendrikmuhs
pushed a commit
to hendrikmuhs/elasticsearch
that referenced
this pull request
Aug 6, 2020
leftover from a previous solution of elastic#57332, which has been discarded relates elastic#60724 fixes elastic#60794
hendrikmuhs
pushed a commit
that referenced
this pull request
Aug 6, 2020
hendrikmuhs
pushed a commit
that referenced
this pull request
Aug 6, 2020
|
Hi, We are affected by this issue on Elastic Cloud. Is there any ETA for the release of 7.10? Thanks |
|
@henryju sorry for the late reply, I was OOF. We revisited the backport and revised our original decision. I can not give you any information about release dates. However, the backport to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
disable optimizations when using scripts in group_by, when scripts using scripts we can not predict the
outcome and we have no query counterpart. Other optimizations for other group_by's are not affected.
fixes #57332
Note: if no group_by is optimized, a warning is created (introduced in #59591)