Migrate some more mapper test cases #61507
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migrate some more mapper test cases from `ESSingleNodeTestCase` to `MapperTestCase`.
nik9000
added
>test
|
Pinging @elastic/es-search (:Search/Mapping) |
romseygeek
approved these changes
Aug 25, 2020
| protected Collection<Class<? extends Plugin>> getPlugins() { | ||
| return pluginList(MapperExtrasPlugin.class); | ||
| protected boolean supportsMeta() { | ||
| return false; | ||
| } |
There was a problem hiding this comment.
A useful byproduct of this exercise is finding all the mappers that we've forgotten to implement meta on!
|
|
||
| @Override | ||
| protected void metaMapping(XContentBuilder b) throws IOException { | ||
| // We serialize extra fields on top of the |
There was a problem hiding this comment.
This comment looks truncated?
|
|
||
| for (String field : new String[] { "a_field", "a_field._index_prefix", "a_field._2gram", "a_field._3gram"}) { | ||
| DocumentMapper mapper = createDocumentMapper(fieldMapping(this::minimalMapping)); | ||
| ParsedDocument doc = mapper.parse(source(b -> b.field("field", "new york city"))); |
| @@ -17,7 +17,6 @@ | |||
| * under the License. | |||
| */ | |||
| apply plugin: 'elasticsearch.yaml-rest-test' | |||
| apply plugin: 'elasticsearch.internal-cluster-test' | |||
| @@ -205,35 +222,39 @@ protected boolean supportsMeta() { | |||
| return true; | |||
| } | |||
|
|
|||
| protected void metaMapping(XContentBuilder b) throws IOException { | |||
There was a problem hiding this comment.
This is a pain, and the really annoying thing is that it's hard to fix these inconsistencies because of BWC. I need to think some more about it.
|
run elasticsearch-ci/packaging-sample-unix |
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this pull request
Aug 25, 2020
Migrate some more mapper test cases from `ESSingleNodeTestCase` to `MapperTestCase`.
nik9000
added a commit
that referenced
this pull request
Aug 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate some more mapper test cases from
ESSingleNodeTestCasetoMapperTestCase.