Skip to content

SQL: Do not resolve self-referencing aliases #62382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 15, 2020
Merged

SQL: Do not resolve self-referencing aliases #62382

merged 1 commit into from
Sep 15, 2020

Conversation

costin
Copy link
Member

@costin costin commented Sep 15, 2020

Prevent the analyzer for trying to resolve aliases on expressions that
reference themselves (or fields within themselves) as that causes
infinite recursion.

Fix #62296

@costin
SQL: Do not resolve self-referencing aliases
5b98641 
Prevent the analyzer for trying to resolve aliases on expressions that
reference themselves (or fields within themselves) as that causes
infinite recursion.

Fix elastic#62296
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-ql (:Query Languages/SQL)

@elasticmachine elasticmachine added the Team:QL (Deprecated) Meta label for query languages team label Sep 15, 2020
matriv
matriv approved these changes Sep 15, 2020
View reviewed changes
Copy link
Contributor

@matriv matriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

astefan
astefan approved these changes Sep 15, 2020
View reviewed changes
Copy link
Contributor

@astefan astefan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bpintea
bpintea approved these changes Sep 15, 2020
View reviewed changes
Copy link
Contributor

@bpintea bpintea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@costin costin merged commit 021d278 into elastic:master Sep 15, 2020
@costin costin deleted the fix/62296 branch September 15, 2020 17:46
costin added a commit that referenced this pull request Sep 15, 2020
@costin
SQL: Do not resolve self-referencing aliases (#62382)
b2e85d5 
Prevent the analyzer for trying to resolve aliases on expressions that
reference themselves (or fields within themselves) as that causes
infinite recursion.

Fix #62296

(cherry picked from commit 021d278)
costin added a commit that referenced this pull request Sep 15, 2020
@costin
SQL: Do not resolve self-referencing aliases (#62382)
834fe3f 
Prevent the analyzer for trying to resolve aliases on expressions that
reference themselves (or fields within themselves) as that causes
infinite recursion.

Fix #62296

(cherry picked from commit 021d278)
(cherry picked from commit b2e85d5)
@costin costin added the v8.0.0 label Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astefan astefan astefan approved these changes

@bpintea bpintea bpintea approved these changes

@matriv matriv matriv approved these changes

Assignees
No one assigned
Labels
:Analytics/SQL SQL querying >bug Team:QL (Deprecated) Meta label for query languages team v7.9.2 v7.10.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SQL: aliasing an aggregate function acting on a nonexistent field generates a StackOverflowError
6 participants
@costin @elasticmachine @astefan @bpintea @matriv @jakelandis