Skip to content

Remove invalid assertion in SearchService #62675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 21, 2020

Conversation

dnhatn
Copy link
Member

@dnhatn dnhatn commented Sep 19, 2020

This assertion does not always hold because there can be a race between putReaderContext and afterIndexRemoved when an index is deleted.

Closes #62624

@dnhatn dnhatn added >test Issues or PRs that are addressing/adding tests :Search/Search Search-related issues that do not fall into other categories v8.0.0 v7.10.0 labels Sep 19, 2020
@dnhatn dnhatn requested a review from jimczi September 19, 2020 20:40
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (:Search/Search)

@elasticmachine elasticmachine added the Team:Search Meta label for search team label Sep 19, 2020
Copy link
Contributor

@jimczi jimczi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dnhatn dnhatn merged commit 64f6052 into elastic:master Sep 21, 2020
@dnhatn dnhatn deleted the fix-testDeleteIndexWhileSearch branch September 21, 2020 20:27
dnhatn added a commit that referenced this pull request Sep 21, 2020
This assertion does not always hold because there can be a race between
`putReaderContext` and `afterIndexRemoved` when an index is deleted.

Closes #62624
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Search/Search Search-related issues that do not fall into other categories Team:Search Meta label for search team >test Issues or PRs that are addressing/adding tests v7.10.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SearchServiceTests#testDeleteIndexWhileSearch failure
4 participants