Skip to content

Tweak the ECS fields in DeprecatedMessage #62855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

pugnascotia
Copy link
Contributor

Make a couple of changes to the ECS fields that are attached to log messages in DeprecatedMessage, as suggested in #61484 (review).

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (:Core/Infra/Logging)

@elasticmachine elasticmachine added the Team:Core/Infra Meta label for core/infra team label Sep 24, 2020
Copy link
Contributor

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I assume there is only 1 deprecation log for Elasticsearch?

Thanks for the adjustments.

At a later stage, the question is probably going to bubble up if the user should be able to configure the namespace but lets keep that for later ;-)

@pugnascotia
Copy link
Contributor Author

Well, there's a log file, and optionally the data stream, but there's only one route into emitting the log messages, so the contents of those locations will be the same.

I'll worry about the namespace if it comes up 😅

@pugnascotia pugnascotia merged commit d0c0ca1 into elastic:master Sep 24, 2020
@pugnascotia pugnascotia deleted the 46106-tweak-deprecation-indexing branch September 24, 2020 10:58
pugnascotia added a commit that referenced this pull request Sep 24, 2020
@pugnascotia
Copy link
Contributor Author

Backported to 7.x in 7771d8b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/Logging Log management and logging utilities >enhancement >non-issue Team:Core/Infra Meta label for core/infra team v7.10.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants