Skip to content

Drain all disruption events until all nodes are healthy on AbstractCoordinatorTestCase #62954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 29, 2020
Merged

Drain all disruption events until all nodes are healthy on AbstractCoordinatorTestCase #62954

merged 2 commits into from
Sep 29, 2020

Conversation

fcofdez
Copy link
Contributor

@fcofdez fcofdez commented Sep 28, 2020

Closes #61711

@fcofdez fcofdez added >test Issues or PRs that are addressing/adding tests :Distributed Coordination/Cluster Coordination Cluster formation and cluster state publication, including cluster membership and fault detection. v8.0.0 Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. v7.10.0 labels Sep 28, 2020
@fcofdez fcofdez requested a review from DaveCTurner September 28, 2020 12:51
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (:Distributed/Cluster Coordination)

DaveCTurner
DaveCTurner reviewed Sep 28, 2020
View reviewed changes
Copy link
Contributor

@DaveCTurner DaveCTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice -- that's much neater than what I was expecting.

Maybe we should just heal all the nodes when setting the finish time initially (if coolDown is true at least). I don't think it's important to keep them disconnected/blackholed through the cooldown phase, and as it stands here we will run until rarely() healing them all.

DaveCTurner
DaveCTurner approved these changes Sep 28, 2020
View reviewed changes
Copy link
Contributor

@DaveCTurner DaveCTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fcofdez
Copy link
Contributor Author

fcofdez commented Sep 29, 2020

Thanks for the review @DaveCTurner !

@fcofdez fcofdez merged commit 6d1f7a7 into elastic:master Sep 29, 2020
fcofdez added a commit to fcofdez/elasticsearch that referenced this pull request Sep 29, 2020
@fcofdez
Drain all disruption events until all nodes are healthy on AbstractCo…
2730859 
…ordinatorTestCase

Backport of elastic#62954
Closes elastic#61711
@fcofdez fcofdez mentioned this pull request Sep 29, 2020
Merged
fcofdez added a commit that referenced this pull request Sep 29, 2020
@fcofdez
Drain all disruption events until all nodes are healthy on AbstractCo…
e0f6b29 
…ordinatorTestCase (#62987)

Backport of #62954
Closes #61711
@original-brownbear original-brownbear mentioned this pull request Oct 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaveCTurner DaveCTurner DaveCTurner approved these changes

Assignees
No one assigned
Labels
:Distributed Coordination/Cluster Coordination Cluster formation and cluster state publication, including cluster membership and fault detection. Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. >test Issues or PRs that are addressing/adding tests v7.10.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CI] CoordinatorTests.testDoesNotPerformElectionWhenRestartingFollower failure
4 participants
@fcofdez @elasticmachine @DaveCTurner @jakelandis