[ML] Adjust wire serialization code after backport to 7.x #63062
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/ml-core (:ml) |
droberts195
reviewed
Sep 30, 2020
There was a problem hiding this comment.
Since master only has to be wire compatible with 7.last you might as well remove the checks completely. It will save doing another PR for this in the future.
The only reason to keep BWC checks in master is if the code that's different in 7.x is so different that to discover it when doing a backport would be a major shock. But that's not the case here - the differences in the older versions are trivial.
Thanks for reminding me. Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adjusts wire serialization code for
ClassificationandAbstractAucRocclasses after backport to 7.xRelates #62160