Add visitor pattern to the triangle tree #63333
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iverase
added
:Analytics/Geo
|
Pinging @elastic/es-analytics-geo (:Analytics/Geo) |
elasticmachine
added
the
Team:Analytics
iverase
commented
Oct 6, 2020
| within = true; | ||
| } | ||
| /** Visitor for triangle interval tree */ | ||
| interface Visitor { |
There was a problem hiding this comment.
Here is where the meat of the PR is.
talevy
approved these changes
Oct 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GeoShape doc values are stored as an interval tree of triangles. Currently the only implementation that uses this structure is the tile aggregation with a custom implementation. In order to add more functionality to this data structure, we should add a visitor pattern.