Dry up AcknowledgedResponse Handling #63335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. `AcknowledgedResponse` should really be two singletons to make things clearer and save some objects and code size. 2. We were duplicating reading this type over and over in a bunch of transport master node actions so I dried that up
original-brownbear
added
>non-issue
:Core/Infra/Core
|
Pinging @elastic/es-core-infra (:Core/Infra/Core) |
|
Jenkins run elasticsearch-ci/packaging-sample-windows |
rjernst
approved these changes
Oct 8, 2020
|
|
||
| import java.io.IOException; | ||
|
|
||
| public abstract class AcknowledgedTransportMasterNodeAction<Request extends MasterNodeRequest<Request>> |
|
Thanks Ryan! |
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Oct 9, 2020
1. It is confusing and unnecessary to handle response deserialization via inheritance and request deserialization via composition. Consistently using composition saves hundreds of lines of code and as a matter of fact also removes some indirection in transport master node action since we pass a reader down to the response handling anyway. 2. Defining `executor` via inheritance but then assuming the return of the method is a constant is confusing and again not in line with how we handle the `executor` definition for other transport actions so this was simplified away as well. Somewhat relates to the dry-up in elastic#63335
original-brownbear
added a commit
that referenced
this pull request
Oct 12, 2020
1. It is confusing and unnecessary to handle response deserialization via inheritance and request deserialization via composition. Consistently using composition saves hundreds of lines of code and as a matter of fact also removes some indirection in transport master node action since we pass a reader down to the response handling anyway. 2. Defining `executor` via inheritance but then assuming the return of the method is a constant is confusing and again not in line with how we handle the `executor` definition for other transport actions so this was simplified away as well. Somewhat relates to the dry-up in #63335
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Oct 14, 2020
These intermediary response types don't contain any information outside of what the shard acknowledged and acknowledged responses contain so this PR removes them. Also, it adds three constants for the three possible states of `ShardsAcknowledgedResponse`. Follow up to elastic#63335
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Oct 26, 2020
1. `AcknowledgedResponse` should really be two singletons to make things clearer and save some objects and code size. 2. We were duplicating reading this type over and over in a bunch of transport master node actions so I dried that up
original-brownbear
added a commit
that referenced
this pull request
Oct 26, 2020
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Oct 26, 2020
1. It is confusing and unnecessary to handle response deserialization via inheritance and request deserialization via composition. Consistently using composition saves hundreds of lines of code and as a matter of fact also removes some indirection in transport master node action since we pass a reader down to the response handling anyway. 2. Defining `executor` via inheritance but then assuming the return of the method is a constant is confusing and again not in line with how we handle the `executor` definition for other transport actions so this was simplified away as well. Somewhat relates to the dry-up in elastic#63335
original-brownbear
added a commit
that referenced
this pull request
Oct 26, 2020
1. It is confusing and unnecessary to handle response deserialization via inheritance and request deserialization via composition. Consistently using composition saves hundreds of lines of code and as a matter of fact also removes some indirection in transport master node action since we pass a reader down to the response handling anyway. 2. Defining `executor` via inheritance but then assuming the return of the method is a constant is confusing and again not in line with how we handle the `executor` definition for other transport actions so this was simplified away as well. Somewhat relates to the dry-up in #63335
original-brownbear
added a commit
that referenced
this pull request
Nov 3, 2020
These intermediary response types don't contain any information outside of what the shard acknowledged and acknowledged responses contain so this PR removes them. Also, it adds three constants for the three possible states of `ShardsAcknowledgedResponse`. Follow up to #63335
original-brownbear
added a commit
that referenced
this pull request
Nov 10, 2020
These intermediary response types don't contain any information outside of what the shard acknowledged and acknowledged responses contain so this PR removes them. Also, it adds three constants for the three possible states of `ShardsAcknowledgedResponse`. Follow up to #63335
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivated by the fact that we keep adding more and more master node actions that return an ack response:
AcknowledgedResponseshould really be two singletons to make things clearer and save some objects and code size.