Skip to content

SQL: Improve parser error message for ESCAPE #63616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 13, 2020
Merged

Conversation

palesz
Copy link
Contributor

@palesz palesz commented Oct 13, 2020

Mentions the list of wildchars in case a wildchar is used as an
ESCAPE character.

Relates #63428

Mentions the list of wildchars in case a wildchar is used as an
`ESCAPE` character.

Relates elastic#63428
@palesz palesz added >bug :Analytics/SQL SQL querying v8.0.0 Team:QL (Deprecated) Meta label for query languages team v7.11.0 v7.10.1 labels Oct 13, 2020
@palesz palesz merged commit 74cbcf8 into elastic:master Oct 13, 2020
@palesz palesz deleted the fix/55108 branch October 13, 2020 14:22
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-ql (:Query Languages/SQL)

palesz pushed a commit that referenced this pull request Oct 13, 2020
Mentions the list of wildchars in case a wildchar is used as an
`ESCAPE` character.

Relates #63428

(cherry picked from commit 74cbcf8)
palesz pushed a commit that referenced this pull request Oct 13, 2020
Mentions the list of wildchars in case a wildchar is used as an
`ESCAPE` character.

Relates #63428

(cherry picked from commit 74cbcf8)
@andreidan andreidan added v7.10.0 and removed v7.10.1 labels Oct 15, 2020
palesz pushed a commit to palesz/elasticsearch that referenced this pull request Oct 19, 2020
Mentions the list of wildchars in case a wildchar is used as an
`ESCAPE` character.

Relates elastic#63428
palesz pushed a commit that referenced this pull request Oct 20, 2020
For a query like `SELECT name FROM test WHERE name LIKE ''%c*'` ES SQL
generates an error. `*` is not a special character in a `LIKE` construct
and it's expected to not needing to be escaped, so the previous query
should work as is.
In the LIKE pattern any `*` character was treated as invalid character
and the usage of `%` or `_` was suggested instead. But `*` is a valid,
acceptable non-wildcard on the right side of the `LIKE` operator.

Fix: #55108
Backports #63616 #63428
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants