Remove direct dependency between ParserContext and MapperService #63741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ParserContext only needs some small portions of MapperService, and certainly does not need to expose MapperService through its current getter method. With this change we address this by keeping references to the needed components rather than the whole MapperService
javanna
added
:Search Foundations/Mapping
|
Pinging @elastic/es-search (:Search/Mapping) |
romseygeek
approved these changes
Oct 15, 2020
| @@ -68,7 +68,7 @@ public static Field field(Settings settings, String path) { | |||
| } | |||
|
|
|||
| public static final TypeParser PARSER = new FixedTypeParser(c -> { | |||
| final IndexSettings indexSettings = c.mapperService().getIndexSettings(); | |||
| final IndexSettings indexSettings = c.getIndexSettings(); | |||
There was a problem hiding this comment.
We can probably change this to use the Version directly as a follow-up
| @@ -99,7 +99,7 @@ public Builder put(MetadataFieldMapper.Builder mapper) { | |||
| return this; | |||
| } | |||
|
|
|||
| public DocumentMapper build(IndexSettings indexSettings, DocumentMapperParser documentMapperParser, IndexAnalyzers indexAnalyzers) { | |||
| public DocumentMapper build() { | |||
There was a problem hiding this comment.
Hah, I'm getting whiplash now.
There was a problem hiding this comment.
haha I had a deja vu making this change, and I did not mean for any of this to happen just two days ago. but I am lucky, I guess :)
Yes, for instance we can remove the need for |
javanna
added a commit
to javanna/elasticsearch
that referenced
this pull request
Oct 15, 2020
…stic#63741) ParserContext only needs some small portions of MapperService, and certainly does not need to expose MapperService through its current getter method. With this change we address this by keeping references to the needed components rather than the whole MapperService
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ParserContext only needs some small portions of MapperService, and certainly does not need to expose MapperService through its current getter method.
With this change we address this by keeping references to the needed components rather than the whole MapperService.