Skip to content

[ML] Rename evaluation metric result fields to value #63809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

dimitris-athanasiou
Copy link
Contributor

Renames data frame analytics _evaluate API results as follows:

  • per class accuracy renamed from accuracy to value
  • per class precision renamed from precision to value
  • per class recall renamed from recall to value
  • auc_roc score renamed to value for both outlier detection and classification

Renames data frame analytics _evaluate API results as follows:

  - per class accuracy renamed from `accuracy` to `value`
  - per class precision renamed from `precision` to `value`
  - per class recall renamed from `recall` to `value`
  - auc_roc `score` renamed to `value` for both outlier detection and classification
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core (:ml)

@benwtrent
Copy link
Member

Looks like you need to update all the yaml tests :).

@dimitris-athanasiou
Copy link
Contributor Author

@benwtrent Ah, I forgot those. Will do.

@dimitris-athanasiou
Copy link
Contributor Author

@elasticmachine update branch

@dimitris-athanasiou
Copy link
Contributor Author

@wwang500 @alvarezmelissa87 Hi! This PR is renaming some fields in the response of the evaluate API. Could you take a look and let me know when it'd be ok for me to merge it?

@wwang500
Copy link

@wwang500 @alvarezmelissa87 Hi! This PR is renaming some fields in the response of the evaluate API. Could you take a look and let me know when it'd be ok for me to merge it?

thanks for the heads-up. feel free to merge it.

@alvarezmelissa87
Copy link

@dimitris-athanasiou - thanks for letting us know! Okay to go ahead and merge it 👌

@dimitris-athanasiou dimitris-athanasiou merged commit 03ed7de into elastic:master Oct 20, 2020
@dimitris-athanasiou dimitris-athanasiou deleted the rename-evaluation-metric-result-fields-to-value branch October 20, 2020 07:30
dimitris-athanasiou added a commit to dimitris-athanasiou/elasticsearch that referenced this pull request Oct 20, 2020
)

Renames data frame analytics _evaluate API results as follows:

  - per class accuracy renamed from `accuracy` to `value`
  - per class precision renamed from `precision` to `value`
  - per class recall renamed from `recall` to `value`
  - auc_roc `score` renamed to `value` for both outlier detection and classification

Backport of elastic#63809
dimitris-athanasiou added a commit that referenced this pull request Oct 20, 2020
…63921)

Renames data frame analytics _evaluate API results as follows:

  - per class accuracy renamed from `accuracy` to `value`
  - per class precision renamed from `precision` to `value`
  - per class recall renamed from `recall` to `value`
  - auc_roc `score` renamed to `value` for both outlier detection and classification

Backport of #63809
pugnascotia pushed a commit to pugnascotia/elasticsearch that referenced this pull request Oct 21, 2020
Renames data frame analytics _evaluate API results as follows:

  - per class accuracy renamed from `accuracy` to `value`
  - per class precision renamed from `precision` to `value`
  - per class recall renamed from `recall` to `value`
  - auc_roc `score` renamed to `value` for both outlier detection and classification
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants