Skip to content

Search - fixed Nullpointer in significant text agg when field does not exist #64144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 26, 2020

Conversation

markharwood
Copy link
Contributor

Constructor now rejects null field type. Added test
Closes #64045

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (:Analytics/Aggregations)

@elasticmachine elasticmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Oct 26, 2020
Copy link
Contributor

@romseygeek romseygeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @markharwood!

@markharwood markharwood merged commit 8fc90c7 into elastic:master Oct 26, 2020
markharwood added a commit to markharwood/elasticsearch that referenced this pull request Oct 26, 2020
…t exist (elastic#64144)

Fixed Nullpointer in significant text agg - added test
Closes elastic#64045
markharwood added a commit that referenced this pull request Oct 26, 2020
…t exist (#64144) (#64157)

Fixed Nullpointer in significant text agg - added test
Closes #64045
@andreidan andreidan added v7.10.0 and removed v7.10.1 labels Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/Aggregations Aggregations Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v7.10.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Significant text aggregation nullpointers if subject field does not exist.
5 participants