Skip to content

Enable geo_distance and geo_bounding_box queries on geo_shape field type #64224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 29, 2020
Merged

Enable geo_distance and geo_bounding_box queries on geo_shape field type #64224

merged 5 commits into from
Oct 29, 2020

Conversation

iverase
Copy link
Contributor

@iverase iverase commented Oct 27, 2020

This commit enables geo_distance and geo_bounding_box queries on geo_shape field type. In addition it enables those queries over geo_point runtime fields as well.

closes #54628

@iverase iverase added >enhancement :Analytics/Geo Indexing, search aggregations of geo points and shapes v8.0.0 v7.11.0 labels Oct 27, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (:Analytics/Geo)

@elasticmachine elasticmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Oct 27, 2020
@iverase iverase mentioned this pull request Oct 27, 2020
Closed
@iverase iverase requested review from jrodewig and talevy October 27, 2020 14:32
talevy
talevy approved these changes Oct 27, 2020
View reviewed changes
Copy link
Contributor

@talevy talevy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks great! I read the docs, the content looks good. There are some English things that @jrodewig could comment on maybe?

jrodewig
jrodewig suggested changes Oct 28, 2020
View reviewed changes
Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good overall. However, there are some grammar issues that need to be fixed before a merge. It also looks like a few of the example snippets target the wrong indices.

@iverase
Copy link
Contributor Author

iverase commented Oct 28, 2020

Thanks you @jrodewig, I added your suggestions!

jrodewig
jrodewig approved these changes Oct 28, 2020
View reviewed changes
Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @iverase!

@iverase iverase merged commit b72be25 into elastic:master Oct 29, 2020
@iverase iverase mentioned this pull request Oct 29, 2020
Merged
@iverase iverase deleted the GeoBoundsCircleQueries branch October 29, 2020 09:50
iverase added a commit that referenced this pull request Oct 29, 2020
@iverase
Enable geo_distance and geo_bounding_box queries on geo_shape field t…
6a51e96 
…ype (#64224) (#64326)
@stevejgordon stevejgordon mentioned this pull request Dec 17, 2020
Closed
@dw-alex dw-alex mentioned this pull request Feb 12, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@talevy talevy talevy approved these changes

@jrodewig jrodewig jrodewig approved these changes

Assignees
No one assigned
Labels
:Analytics/Geo Indexing, search aggregations of geo points and shapes >enhancement Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v7.11.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable geo_distance and geo_bounding_box queries on geo_shape field type
5 participants
@iverase @elasticmachine @talevy @jrodewig @jakelandis