Dry up TransportResponseHandler #64395
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The majority of implementations of this interface run on `SAME`. Drying this up saves some duplication and also makes it a little easier to understand what callbacks won't fork-off when reading the code.
original-brownbear
added
>non-issue
:Core/Infra/Core
|
Pinging @elastic/es-core-infra (:Core/Infra/Core) |
|
Jenkins run elasticsearch-ci/bwc |
…response-handlers
rjernst
reviewed
Nov 3, 2020
yea that's the cleaner approach indeed -> moved to that now thanks! :) |
|
Jenkins run elasticsearch-ci/2 |
|
Thanks Ryan! |
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Nov 5, 2020
The majority of implementations of this interface run on `SAME`. Drying this up saves some duplication and also makes it a little easier to understand what callbacks won't fork-off when reading the code.
original-brownbear
added a commit
that referenced
this pull request
Nov 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I keep typing this over and over so I figured I'd dry it up:
The majority of implementations of this interface run on
SAME.Drying this up saves some duplication and also makes it a little
easier to understand what callbacks won't fork-off when reading the
code.