Skip to content

Fix CoordinatorTests.testUnresponsiveLeaderDetectedEventually #64462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 2, 2020
Merged

Fix CoordinatorTests.testUnresponsiveLeaderDetectedEventually #64462

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4055879
Fix CoordinatorTests.testUnresponsiveLeaderDetectedEventually
fcofdez Nov 2, 2020
fecb391
Take into account publication timeout
fcofdez Nov 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions server/src/test/java/org/elasticsearch/cluster/coordination/CoordinatorTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -539,6 +539,14 @@ public void testUnresponsiveLeaderDetectedEventually() {
+ defaultMillis(PUBLISH_TIMEOUT_SETTING)
// there might be a term bump causing another election
+ DEFAULT_ELECTION_DELAY
// in clusters with 5 nodes the chances of concurrent elections
// increase, meaning that it takes longer to get a leader elected
// so we should take into account those cases to ensure that the
// cluster stabilises over time. See #63918 for a really messy scenario.
+ DEFAULT_ELECTION_DELAY
// additionally take into account that publications might take longer
// until the new leader detects that the old leader is unresponsive
+ defaultMillis(PUBLISH_TIMEOUT_SETTING)

// then wait for both of:
+ Math.max(
Expand Down