Skip to content

Simplify creation of CentroidCalculator objects #64619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 6, 2020
Merged

Simplify creation of CentroidCalculator objects #64619

merged 3 commits into from
Nov 6, 2020

Conversation

iverase
Copy link
Contributor

@iverase iverase commented Nov 5, 2020

This change the CentroidCalculator so:

  • CentroidCalculator is built by adding geometries instead of other CentroidCalculators.
  • Creation of those objects is responsibility now of BinaryGeoShapeDocValuesField.
  • There are no dependencies with the CoordinateEncoder. For doing that, we have added two new methods to the CoordinateEncoder interface for normalising the dimensions.

@iverase iverase added :Analytics/Geo Indexing, search aggregations of geo points and shapes >refactoring v8.0.0 v7.11.0 labels Nov 5, 2020
@iverase iverase requested a review from talevy November 5, 2020 07:32
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (:Analytics/Geo)

@elasticmachine elasticmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Nov 5, 2020
talevy
talevy approved these changes Nov 6, 2020
View reviewed changes
Copy link
Contributor

@talevy talevy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just left a note about the java comment that can probably be removed since the encoder is normalizing now (which makes a lot of sense, thanks!)

@iverase iverase merged commit 47da916 into elastic:master Nov 6, 2020
@iverase iverase deleted the centroidCalculator branch November 6, 2020 07:59
@iverase iverase mentioned this pull request Nov 6, 2020
Merged
iverase added a commit that referenced this pull request Nov 6, 2020
@iverase
Simplify creation of CentroidCalculator objects (#64619) (#64686)
d746eee 
Creation of those objects is responsibility now of BinaryGeoShapeDocValuesField.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@talevy talevy talevy approved these changes

Assignees
No one assigned
Labels
:Analytics/Geo Indexing, search aggregations of geo points and shapes >refactoring Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v7.11.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iverase @elasticmachine @talevy @jakelandis