Remove Dead Code and Duplication from Metadata #64938
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just some random spots I found while researching other things.
original-brownbear
added
>non-issue
:Distributed Indexing/Distributed
|
Pinging @elastic/es-distributed (:Distributed/Distributed) |
elasticmachine
added
the
Team:Distributed (Obsolete)
|
@elasticmachine update branch |
henningandersen
approved these changes
Dec 21, 2020
| listener.onFailure(e); | ||
| return; | ||
| } | ||
| mappingsResult = state.metadata().findMappings(concreteIndices, indicesService.getFieldFilter()); |
There was a problem hiding this comment.
Should we not also remove the if (!doneXXXX) from the two blocks below in the same go?
There was a problem hiding this comment.
I don't think I can remove those with the strange way these requests work (reading features from an array we could have duplicate entries)?
|
Thanks Henning! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just some random spots I found while researching other things.
(only partly applies to
7.11in a backport since the types utils need to be kept around there)