Fixes GeoLineAggregator bugs #65521
Merged
Fixes GeoLineAggregator bugs #65521
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit unmutes and fixes tests around some GeoLineAggregator edge cases. - MergedGeoLines had a silly bug where it was accepting InternalGeoLines that were empty - "complete" is measured by the heap-mode of the BucketedSort, which is a problem since if the length of the data equals the max-size, then it is difficult to know whether any values were discarded. - GeoLineBucketSort had an array-resizing bug s/>/>= Fixes elastic#65473.
talevy
added
>bug
:Analytics/Geo
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
iverase
approved these changes
Dec 2, 2020
talevy
added a commit
that referenced
this pull request
Dec 2, 2020
This commit unmutes and fixes tests around some GeoLineAggregator edge cases. - MergedGeoLines had a silly bug where it was accepting InternalGeoLines that were empty - "complete" is measured by the heap-mode of the BucketedSort, which is a problem since if the length of the data equals the max-size, then it is difficult to know whether any values were discarded. - GeoLineBucketSort had an array-resizing bug s/>/>= Fixes #65473.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit unmutes and fixes tests around some GeoLineAggregator edge
cases.
that were empty
since if the length of the data equals the max-size, then it is difficult to know
whether any values were discarded.
Fixes #65473.