Adds a consistent shard index to ShardSearchRequest #65706
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change ensures that the shard index that is used to tiebreak documents with identical sort remains consistent between two requests that target the same shards. The index is now always computed from the natural order of the shards in the search request. This change also adds the consistent shard index to the ShardSearchRequest. That allows the slice builder to use this information to build more balanced slice query. Relates elastic#56828
jimczi
added
>enhancement
:Search/Search
|
Pinging @elastic/es-search (Team:Search) |
mayya-sharipova
approved these changes
Dec 2, 2020
There was a problem hiding this comment.
@jimczi Thanks Jim, this LGTM. Nice to get rid of irrelevant indexRoutings and preference fields in ShardSearchRequest.
| } | ||
| } | ||
|
|
||
| int shardIndex = request.shardIndex() != -1 ? request.shardIndex() : request.shardId().id(); |
There was a problem hiding this comment.
I guess a case when shardIdex() = -1 (when a coordinating node is v < 8.0) and there is a preference or indexRouting present in scroll slice is a very rare case, and we can disregard it.
There was a problem hiding this comment.
Yes, that's my reasoning too.
This was referenced Dec 7, 2020
jimczi
added a commit
that referenced
this pull request
Dec 7, 2020
jimczi
added a commit
that referenced
this pull request
Dec 7, 2020
This change ensures that the shard index that is used to tiebreak documents with identical sort remains consistent between two requests that target the same shards. The index is now always computed from the natural order of the shards in the search request. This change also adds the consistent shard index to the ShardSearchRequest. That allows the slice builder to use this information to build more balanced slice query. Relates #56828
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ensures that the shard index that is used to tiebreak documents with identical sort
remains consistent between two requests that target the same shards. The index is now always computed from the
natural order of the shards in the search request.
This change also adds the consistent shard index to the ShardSearchRequest. That allows the slice builder
to use this information to build more balanced slice query.
Relates #56828