Avoid passing Lucene version to Store#createEmpty. #65783
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Store already holds onto index settings, so it can look up the version directly. This helps consolidate version checks in a smaller number of places.
3 tasks
jtibshirani
added
:Distributed Indexing/Store
elasticmachine
added
the
Team:Distributed (Obsolete)
|
Pinging @elastic/es-distributed (Team:Distributed) |
jtibshirani
added a commit
to jtibshirani/elasticsearch
that referenced
this pull request
Dec 3, 2020
Store already holds onto index settings, so it can look up the version directly. This helps consolidate version checks in a smaller number of places.
jtibshirani
added a commit
that referenced
this pull request
Dec 4, 2020
This is a forward-port of a bugfix we found as part of backporting #65783.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Store already holds onto index settings, so it can look up the version directly.
This helps consolidate version checks in a smaller number of places.
Relates to #65399.