Fix IndexFoldersDeletionListenerIT.testListenersInvokedWhenIndexIsRelocated #66329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlrx
added
>test
elasticmachine
added
the
Team:Distributed (Obsolete)
|
Pinging @elastic/es-distributed (Team:Distributed) |
|
Thanks David |
tlrx
added a commit
to tlrx/elasticsearch
that referenced
this pull request
Dec 17, 2020
The tests testListenersInvokedWhenIndexIsRelocated and testListenersInvokedWhenIndexIsDangling fail on CI with errors like: java.lang.AssertionError: Expecting no shards deleted on node node_t4 at __randomizedtesting.SeedInfo.seed(...) at org.junit.Assert.fail(Assert.java:88) at org.junit.Assert.assertTrue(Assert.java:41) at org.elasticsearch.plugins.IndexFoldersDeletionListenerIT. testListenersInvokedWhenIndexIsDangling (IndexFoldersDeletionListenerIT.java:189) This commit tries to make those tests more stable by starting all nodes upfront, by waiting for no rebalancing/ relocations before checking the previous assertions and by extending a bit the time of some assertBusy() as on CI it can take more than 10 sec for pending deletes to be processed.
tlrx
added a commit
to tlrx/elasticsearch
that referenced
this pull request
Dec 17, 2020
The tests testListenersInvokedWhenIndexIsRelocated and testListenersInvokedWhenIndexIsDangling fail on CI with errors like: java.lang.AssertionError: Expecting no shards deleted on node node_t4 at __randomizedtesting.SeedInfo.seed(...) at org.junit.Assert.fail(Assert.java:88) at org.junit.Assert.assertTrue(Assert.java:41) at org.elasticsearch.plugins.IndexFoldersDeletionListenerIT. testListenersInvokedWhenIndexIsDangling (IndexFoldersDeletionListenerIT.java:189) This commit tries to make those tests more stable by starting all nodes upfront, by waiting for no rebalancing/ relocations before checking the previous assertions and by extending a bit the time of some assertBusy() as on CI it can take more than 10 sec for pending deletes to be processed.
tlrx
added a commit
that referenced
this pull request
Dec 17, 2020
…ocated (#66329) (#66511) The tests testListenersInvokedWhenIndexIsRelocated and testListenersInvokedWhenIndexIsDangling fail on CI with errors like: java.lang.AssertionError: Expecting no shards deleted on node node_t4 at __randomizedtesting.SeedInfo.seed(...) at org.junit.Assert.fail(Assert.java:88) at org.junit.Assert.assertTrue(Assert.java:41) at org.elasticsearch.plugins.IndexFoldersDeletionListenerIT. testListenersInvokedWhenIndexIsDangling (IndexFoldersDeletionListenerIT.java:189) This commit tries to make those tests more stable by starting all nodes upfront, by waiting for no rebalancing/ relocations before checking the previous assertions and by extending a bit the time of some assertBusy() as on CI it can take more than 10 sec for pending deletes to be processed.
tlrx
added a commit
that referenced
this pull request
Dec 17, 2020
The tests testListenersInvokedWhenIndexIsRelocated and testListenersInvokedWhenIndexIsDangling fail on CI with errors like: java.lang.AssertionError: Expecting no shards deleted on node node_t4 at __randomizedtesting.SeedInfo.seed(...) at org.junit.Assert.fail(Assert.java:88) at org.junit.Assert.assertTrue(Assert.java:41) at org.elasticsearch.plugins.IndexFoldersDeletionListenerIT. testListenersInvokedWhenIndexIsDangling (IndexFoldersDeletionListenerIT.java:189) This commit tries to make those tests more stable by starting all nodes upfront, by waiting for no rebalancing/ relocations before checking the previous assertions and by extending a bit the time of some assertBusy() as on CI it can take more than 10 sec for pending deletes to be processed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests
testListenersInvokedWhenIndexIsRelocatedandtestListenersInvokedWhenIndexIsDanglingsometimes fail on CI which errors like:This commit tries to make those tests more stable by starting all nodes upfront, by waiting for no rebalancing/relocations before checking the previous assertions and by extending a bit the time of some
assertBusy()as on CI it can take more than 10 sec for pending deletes to be processed.