Reduce Overhead of RepositoryData Cache for Large Repositories #66587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds caching the fact that `RepositoryData` was too large to be cached so we don't serialize it over and over just to find out we can't cache it.
original-brownbear
added
>non-issue
:Distributed Coordination/Snapshot/Restore
elasticmachine
added
the
Team:Distributed (Obsolete)
|
Pinging @elastic/es-distributed (Team:Distributed) |
| /** | ||
| * Cached serialized repository data or placeholder to keep track of the fact that data for a generation was too large to be cached. | ||
| */ | ||
| private static final class CachedRepositoryData { |
There was a problem hiding this comment.
I figured I'd encapsulate this a little (even though it adds a bunch of lines) because the Tuple access is quite hard to read and it's used in a bunch of spots.
|
Thanks Tanguy! |
original-brownbear
deleted the
better-efficiency-repository-data-cache
branch
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Dec 18, 2020
…ic#66587) This adds caching the fact that `RepositoryData` was too large to be cached so we don't serialize it over and over just to find out we can't cache it.
original-brownbear
added a commit
that referenced
this pull request
Dec 18, 2020
… (#66609) This adds caching the fact that `RepositoryData` was too large to be cached so we don't serialize it over and over just to find out we can't cache it.
original-brownbear
restored the
better-efficiency-repository-data-cache
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds caching the fact that
RepositoryDatawas too large to becached so we don't serialize it over and over just to find out we can't
cache it (which obviously is quite costly for larger
RepositoryDatainstances).relates #66042