Skip netty4 yaml test in FIPS mode #66842
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "Netty loaded" YAML test asserts that the configured transport is "netty4", however when in FIPS mode, the tests enable security and the configured transport is "security4". This change skips the netty4 yaml test when running in FIPS mode. Resolves: elastic#66818
tvernum
added
>test
|
Pinging @elastic/es-security (Team:Security) |
|
The original plan was to add this to the yml test: However, that means that the test suite ended up with no tests, which fails the build. |
tvernum
added a commit
to tvernum/elasticsearch
that referenced
this pull request
Dec 29, 2020
The "Netty loaded" YAML test asserts that the configured transport is "netty4", however when in FIPS mode, the tests enable security and the configured transport is "security4". This change skips the netty4 yaml test when running in FIPS mode. Resolves: elastic#66818 Backport of: elastic#66842
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "Netty loaded" YAML test asserts that the configured transport is
"netty4", however when in FIPS mode, the tests enable security and the
configured transport is "security4".
This change skips the netty4 yaml test when running in FIPS mode.
Resolves: #66818