Improve LocalStateMonitoring for tests. #66997
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martijnvg
added
>test
|
Pinging @elastic/es-core-features (Team:Core/Features) |
|
Only targeting master branch now, to see how the CI runs the tests that are unmuted. If tests do fail then I will mute these tests again. I will backport the changes to |
martijnvg
force-pushed
the
improve_LocalStateMonitoring
branch
from
dff2394 to
a62b2aa
Compare
…ons for ccr and enrich. The data stream plugin and dummy transport actions that are added to LocalStateMonitoring will allow for monitoring java integration tests to function properly without printing error messages that make debugging harder. For example the data stream plugin was added so that index templates with data streams can be added without failing constantly in the background and enrich stats dummy transport action so that the EnrichStatsCollector doesn't fail. Also unmutes tests that were muted via elastic#66586, to have another opportunity to look at logs without all the noise, perhaps all these errors contributed to the test failures.
martijnvg
force-pushed
the
improve_LocalStateMonitoring
branch
from
a62b2aa to
3aa7297
Compare
martijnvg
changed the title
martijnvg
commented
Jan 5, 2021
|
|
||
| @Override | ||
| public List<ActionHandler<? extends ActionRequest, ? extends ActionResponse>> getActions() { | ||
| var actions = super.getActions(); |
There was a problem hiding this comment.
Additional note: It is not possible to add the ccr / enrich plugins (like with data streams), because the monitoring gradle project can't rely on these gradle modules, because both ccr and enrich gradle projects already depend on the monitoring gradle project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds data-streams plugin and dummy stats actions for ccr and enrich to LocalStateMonitoring.
The data stream plugin and dummy transport actions that are added to LocalStateMonitoring
will allow for monitoring java integration tests to function properly without printing error
messages that make debugging harder. For example the data stream plugin was added so that
index templates with data streams can be added without failing constantly in the background and
enrich stats dummy transport action so that the EnrichStatsCollector doesn't fail.
Also unmutes tests that were muted via #66586, to have another opportunity to look at logs without all the noise,
perhaps all these errors contributed to the test failures.