Fix bug with nested and filters agg #67043
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
Fixes a bug where nested documents that match a filter in the `filters` agg will be counted as matching the filter. Usually nested documents only match if you explicitly ask to match them. Worse, we only mach them in the "filter by filter" mode that we wrote to speed up date_histogram. The `filters` agg is fairly rare, but with elastic#63643 we run `date_histogram` and `range` aggregations using `filters.
nik9000
commented
Jan 5, 2021
| }, | ||
| ft | ||
| ); | ||
| } |
There was a problem hiding this comment.
This doesn't end up finding the bug but I figured it was worth keeping anyway.
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this pull request
Jan 7, 2021
Fixes a bug where nested documents that match a filter in the `filters` agg will be counted as matching the filter. Usually nested documents only match if you explicitly ask to match them. Worse, we only mach them in the "filter by filter" mode that we wrote to speed up date_histogram. The `filters` agg is fairly rare, but with elastic#63643 we run `date_histogram` and `range` aggregations using `filters.
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this pull request
Jan 7, 2021
Fixes a bug where nested documents that match a filter in the `filters` agg will be counted as matching the filter. Usually nested documents only match if you explicitly ask to match them. Worse, we only mach them in the "filter by filter" mode that we wrote to speed up date_histogram. The `filters` agg is fairly rare, but with elastic#63643 we run `date_histogram` and `range` aggregations using `filters`.
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this pull request
Jan 7, 2021
When I merged elastic#67043 it had an integration test for the thing it was fixing but it still fails in the bwc tests. Yikes! I should know better but life is life. Anyway, this updates the skip to ignore the test for now. I'll reenable once the backport is in.
nik9000
added a commit
that referenced
this pull request
Jan 7, 2021
Fixes a bug where nested documents that match a filter in the `filters` agg will be counted as matching the filter. Usually nested documents only match if you explicitly ask to match them. Worse, we only mach them in the "filter by filter" mode that we wrote to speed up date_histogram. The `filters` agg is fairly rare, but with #63643 we run `date_histogram` and `range` aggregations using `filters.
nik9000
added a commit
that referenced
this pull request
Jan 7, 2021
Fixes a bug where nested documents that match a filter in the `filters` agg will be counted as matching the filter. Usually nested documents only match if you explicitly ask to match them. Worse, we only mach them in the "filter by filter" mode that we wrote to speed up date_histogram. The `filters` agg is fairly rare, but with #63643 we run `date_histogram` and `range` aggregations using `filters`.
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this pull request
Jan 7, 2021
Now that elastic#67043 has been backported we can update the skip so the bwc tests don't complain.
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this pull request
Jan 7, 2021
Now that elastic#67043 has been backported we can update the skip so the bwc tests don't complain.
This was referenced Jan 7, 2021
nik9000
added a commit
that referenced
this pull request
Jan 7, 2021
nik9000
added a commit
that referenced
this pull request
Jan 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where nested documents that match a filter in the
filtersagg will be counted as matching the filter. Usually nested documents
only match if you explicitly ask to match them. Worse, we only mach them
in the "filter by filter" mode that we wrote to speed up date_histogram.
The
filtersagg is fairly rare, but with #63643 we rundate_histogramandrangeaggregations using `filters.