Skip to content

Use test cluster exclusive in CancellableTasksIT #67058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 13, 2021

Conversation

dnhatn
Copy link
Member

@dnhatn dnhatn commented Jan 5, 2021

testRemoveBanParentsOnDisconnect disconnects some nodes and leaves the cluster in an unhealthy state, which fails other tests. We can reconnect nodes after that test. However, this commit chooses to run this suite test-cluster exclusive instead because it is simpler and more stable.

Closes #66520

@dnhatn dnhatn added >test Issues or PRs that are addressing/adding tests :Distributed Coordination/Task Management Issues for anything around the Tasks API - both persistent and node level. v8.0.0 v7.12.0 v7.11.1 labels Jan 5, 2021
@dnhatn dnhatn requested a review from ywelsch January 5, 2021 22:09
@elasticmachine elasticmachine added the Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. label Jan 5, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

Copy link
Contributor

@ywelsch ywelsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dnhatn dnhatn merged commit eaa0d92 into elastic:master Jan 13, 2021
@dnhatn dnhatn deleted the fix-CancellableTasksIT branch January 13, 2021 14:01
dnhatn added a commit that referenced this pull request Jan 13, 2021
testRemoveBanParentsOnDisconnect disconnects some nodes and leaves the 
cluster in an unhealthy state, which fails other tests. We can reconnect
nodes after that test. However, this commit chooses to run this suite
test-cluster exclusive instead because it is simpler and more stable.

Closes #6652
dnhatn added a commit that referenced this pull request Jan 13, 2021
testRemoveBanParentsOnDisconnect disconnects some nodes and leaves the
cluster in an unhealthy state, which fails other tests. We can reconnect
nodes after that test. However, this commit chooses to run this suite
test-cluster exclusive instead because it is simpler and more stable.

Closes #6652
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed Coordination/Task Management Issues for anything around the Tasks API - both persistent and node level. Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. >test Issues or PRs that are addressing/adding tests v7.11.1 v7.12.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

testBanOnlyNodesWithOutstandingDescendantTasks fails
4 participants