Fix ignoring require_alias parameter in high level rest client #67865
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticmachine
added
the
Team:Data Management
|
Pinging @elastic/es-core-features (Team:Core/Features) |
|
Pinging @elastic/clients-team (Team:Clients) |
|
@elasticmachine ok to test @swallez - can you please take a look at this PR ? |
|
@elasticmachine update branch |
|
@martijnvg, can this PR be merged now? |
|
@gaobinlong Thanks for the ping, I will look into this today. |
|
@elasticmachine update branch |
|
@elasticmachine run elasticsearch-ci/2 |
martijnvg
approved these changes
Apr 20, 2021
There was a problem hiding this comment.
Thanks @gaobinlong for fixing this! And apologies to the delay.
I will merge this once pr ci is green.
martijnvg
pushed a commit
to martijnvg/elasticsearch
that referenced
this pull request
Apr 20, 2021
…astic#67865) The main changes are: * Set the require_alias parameter in the reindex, index and update methods in RequestConverters class. * Test that the parameter can be parsed correctly. Closes elastic#67819.
martijnvg
added a commit
that referenced
this pull request
Apr 20, 2021
…1914) Backporting #67865 to 7.x branch. The main changes are: * Set the require_alias parameter in the reindex, index and update methods in RequestConverters class. * Test that the parameter can be parsed correctly. Closes #67819. Co-authored-by: bellengao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #67819.
The main changes are:
require_aliasparameter in thereindex,indexandupdatemethods inRequestConvertersclass.