Extend async search keep alive #67877
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnhatn
force-pushed
the
extend-keep-alive
branch
from
a144a06 to
47e13b1
Compare
dnhatn
force-pushed
the
extend-keep-alive
branch
from
77b21fd to
15f046d
Compare
dnhatn
added
:Search/Search
|
Pinging @elastic/es-search (Team:Search) |
jimczi
approved these changes
Jan 25, 2021
x-pack/plugin/async-search/src/main/java/org/elasticsearch/xpack/search/AsyncSearchTask.java
Outdated
Show resolved
Hide resolved
x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/async/AsyncTaskIndexService.java
Outdated
Show resolved
Hide resolved
|
Thanks Jim! |
dnhatn
added a commit
that referenced
this pull request
Jan 26, 2021
There can be a race between two GET async search requests, and the one with a lower keep_alive parameter wins the race. This scenario is not desirable as we should retain the search result for all requests. This commit ensures the keep_alive is extended and never goes backward.
|
@jimczi I thought we ended up agreeing that following elastic/kibana#89570 we actually don't need this restriction. |
|
Good call @lizozom , we added the restriction before the design change in elastic/kibana#89570 but +1 to revert. I'll open a new PR. |
jimczi
added a commit
to jimczi/elasticsearch
that referenced
this pull request
Feb 10, 2021
This reverts commit 244fc95.
jimczi
added a commit
that referenced
this pull request
Feb 10, 2021
|
Reverted by #67877 |
jimczi
added a commit
that referenced
this pull request
Feb 10, 2021
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There can be a race between two GET async search requests, and the one with a lower keep_alive parameter wins the race. This scenario is not desirable as we should retain the search result for all requests. This commit ensures the keep_alive is extended and never goes backward.
Relates elastic/kibana#88599