Skip to content

EQL: improve EQL request/response serialization tests for bwc versions #68339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 2, 2021

Conversation

astefan
Copy link
Contributor

@astefan astefan commented Feb 1, 2021

Improves testing for stream serialization/deserialization of EqlSearchResponse/Request considering bwc versions.

@astefan astefan added >enhancement >test Issues or PRs that are addressing/adding tests v8.0.0 :Analytics/EQL EQL querying v7.12.0 v7.11.1 v7.10.3 labels Feb 1, 2021
@elasticmachine elasticmachine added the Team:QL (Deprecated) Meta label for query languages team label Feb 1, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-ql (Team:QL)

@astefan astefan requested a review from costin February 1, 2021 22:47
Copy link
Member

@costin costin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@astefan astefan merged commit 3a1f5dc into elastic:master Feb 2, 2021
@astefan astefan deleted the eql_serialization_fix branch February 2, 2021 07:11
astefan added a commit to astefan/elasticsearch that referenced this pull request Feb 2, 2021
astefan added a commit to astefan/elasticsearch that referenced this pull request Feb 2, 2021
astefan added a commit to astefan/elasticsearch that referenced this pull request Feb 2, 2021
astefan added a commit that referenced this pull request Feb 2, 2021
astefan added a commit that referenced this pull request Feb 2, 2021
astefan added a commit that referenced this pull request Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/EQL EQL querying >enhancement Team:QL (Deprecated) Meta label for query languages team >test Issues or PRs that are addressing/adding tests v7.10.3 v7.11.1 v7.12.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants