Add ?storage arg to mount API #68431
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a new flag, `?partial_local_copy`, indicating that the local copy of a searchable snapshot should be partial rather than complete, enabling the frozen tier functionality.
DaveCTurner
added
>enhancement
:Distributed Coordination/Snapshot/Restore
elasticmachine
added
the
Team:Distributed (Obsolete)
|
Pinging @elastic/es-distributed (Team:Distributed) |
|
@elasticmachine please run elasticsearch-ci/2 (unrelated failure, reproduces without these changes) |
DaveCTurner
changed the title
ywelsch
approved these changes
Feb 3, 2021
| @@ -72,7 +72,8 @@ private void executeTest(final String indexName, final Client client) throws Exc | |||
| indexName, | |||
| Settings.builder().put(IndexMetadata.SETTING_INDEX_HIDDEN, randomBoolean()).build(), | |||
| Strings.EMPTY_ARRAY, | |||
| true | |||
| true, | |||
| randomFrom(MountSearchableSnapshotRequest.Storage.FULL_COPY, MountSearchableSnapshotRequest.Storage.SHARED_CACHE) | |||
There was a problem hiding this comment.
just randomFrom(Storage.values())?
|
@elasticmachine please run elasticsearch-ci/2 |
tlrx
approved these changes
Feb 4, 2021
| @@ -162,6 +186,13 @@ public Settings indexSettings() { | |||
| return ignoredIndexSettings; | |||
| } | |||
|
|
|||
| /** | |||
| * @return whether the local copy of the snapshot is partial ({@code true}) or complete ({@code false}). | |||
There was a problem hiding this comment.
Maybe drop (or adjust the doc) here?
|
YOLO merge to the feature branch, a PR to master is impending. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a new flag,
?storage, controlling the storageof the local copy of a searchable snapshot.