Use sequential access of stored fields in CCR #68961
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnhatn
force-pushed
the
ccr-optimize-stored-fields
branch
3 times, most recently
from
e7ae7e4 to
3d2dcde
Compare
dnhatn
force-pushed
the
ccr-optimize-stored-fields
branch
from
3d2dcde to
68053ef
Compare
|
Below is a benchmark from |
dnhatn
added
:Distributed Indexing/CCR
elasticmachine
added
the
Team:Distributed (Obsolete)
|
Pinging @elastic/es-distributed (Team:Distributed) |
romseygeek
reviewed
Feb 16, 2021
| } | ||
| assertFalse(snapshot.useSequentialStoredFieldsReader()); | ||
| } | ||
| // disable optimization for non-sequential accesses |
There was a problem hiding this comment.
This comment doesn't seem to correspond with the test below?
There was a problem hiding this comment.
Good catch. I fixed in 3eb853d.
jimczi
approved these changes
Feb 16, 2021
| } | ||
| } | ||
|
|
||
| private static boolean hasSequentialAccess(ScoreDoc[] scoreDocs) { |
There was a problem hiding this comment.
You can avoid the loop entirely like in FetchPhase#hasSequentialDocs
There was a problem hiding this comment.
This is a bit different. We can access documents out of order instead of ascending like in the fetch phase.
|
run elasticsearch-ci/2 |
|
@romseygeek @jimczi Thanks for review. |
dnhatn
added a commit
that referenced
this pull request
Feb 16, 2021
This commit re-introduces the sequential access of stored fields in CCR. Unlike the previous change, we apply this optimization only when we are accessing 10+ consecutive document ids. I ran a CCR benchmark, and this change increased the indexing throughput on the leader by 30%.
dnhatn
added a commit
that referenced
this pull request
Feb 22, 2021
We can't enable the sequential access optimization for stored fields of changes snapshots used in peer recoveries because they are accessed by multiple threads. Relates to #68961
dnhatn
added a commit
to dnhatn/elasticsearch
that referenced
this pull request
Feb 22, 2021
We can't enable the sequential access optimization for stored fields of changes snapshots used in peer recoveries because they are accessed by multiple threads. Relates to elastic#68961
dnhatn
added a commit
that referenced
this pull request
Feb 23, 2021
We can't enable the sequential access optimization for stored fields of changes snapshots used in peer recoveries because they are accessed by multiple threads. Relates to #68961
dnhatn
added a commit
that referenced
this pull request
Feb 23, 2021
We can't enable the sequential access optimization for stored fields of changes snapshots used in peer recoveries because they are accessed by multiple threads. Relates to #68961
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit re-introduces the sequential access of stored fields in CCR. Unlike the previous change, we apply this optimization only when we are accessing 10+ consecutive document ids.
I ran a CCR benchmark, and this change increased the indexing throughput on the leader by 30%.