Skip to content

Relaxing score comparisons for rank_eval tests #68976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 16, 2021

Conversation

cbuescher
Copy link
Member

The currently allowed delta in this tests is to strict to account for slight floating point
differences across different platforms, e.g. ARM.

Closes #68936

The currently allowed delta in this tests is to strict to account for slight floating point
differences across different platforms, e.g. ARM.

Closes elastic#68936
@cbuescher cbuescher added >test Issues or PRs that are addressing/adding tests :Search Relevance/Ranking Scoring, rescoring, rank evaluation. v8.0.0 v7.12.0 labels Feb 15, 2021
@elasticmachine elasticmachine added the Team:Search Meta label for search team label Feb 15, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

@cbuescher
Copy link
Member Author

@elasticmachine run elasticsearch-ci/2

Copy link
Contributor

@droberts195 droberts195 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The CI failure looks like that SSL certificate problem so hopefully if you merge in latest master it will pass.

@cbuescher
Copy link
Member Author

@elasticmachine update branch

@cbuescher cbuescher merged commit 45b1c46 into elastic:master Feb 16, 2021
cbuescher pushed a commit that referenced this pull request Feb 16, 2021
The currently allowed delta in this tests is to strict to account for slight floating point
differences across different platforms, e.g. ARM.

Closes #68936
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Search Relevance/Ranking Scoring, rescoring, rank evaluation. Team:Search Meta label for search team >test Issues or PRs that are addressing/adding tests v7.12.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] RankEvalIT failing on ARM workers
4 participants