Move runtime fields to server #69223
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Except the whitelists around grok and dissect which stay for now separate as they depend on grok and dissect
javanna
added
:Search/Search
|
Pinging @elastic/es-search (Team:Search) |
nik9000
reviewed
Feb 19, 2021
| @@ -259,7 +259,7 @@ public String getType() { | |||
|
|
|||
| @Override | |||
| public Set<ScriptContext<?>> getSupportedContexts() { | |||
| return Set.of(DoubleFieldScript.CONTEXT); | |||
| return Set.of(); | |||
There was a problem hiding this comment.
I'm kind of surprised this passes without this.
There was a problem hiding this comment.
I poked a bit with this and I think this is because all the runtime fields contexts are now built-in and applied by ScriptModule by default.
There was a problem hiding this comment.
Weird! I thought the scripting infra wouldn't send a Script to an engine that didn't support the context. But it looks like that isn't how it works. It more like script engines can make new contexts with this thing.
romseygeek
approved these changes
Feb 19, 2021
| @@ -219,10 +219,6 @@ protected static boolean parseObjectOrDocumentTypeProperties(String fieldName, O | |||
| if (value.equalsIgnoreCase("strict")) { | |||
| builder.dynamic(Dynamic.STRICT); | |||
| } else if (value.equalsIgnoreCase("runtime")) { | |||
| if (parserContext.supportsDynamicRuntimeMappings() == false) { | |||
There was a problem hiding this comment.
So good to see this gone!
There was a problem hiding this comment.
yes that is what I thought too. There is more to do to simplify the abstractions here, but removing the extension point and some of the shenanigans around it feels good.
nik9000
approved these changes
Feb 19, 2021
jdconrad
approved these changes
Feb 19, 2021
javanna
added a commit
to javanna/elasticsearch
that referenced
this pull request
Feb 22, 2021
This commit makes a start on moving runtime fields to server. The runtime field types are now built-in. The dynamic fields builder extension (needed to make dynamic:runtime work) is removed: further simplifications are needed but are left for a follow-up. It is still possible to plug in custom runtime field types through the same extension point that the xpack plugin used to use. The runtime fields script contexts are now also moved to server, and the corresponding whitelists are part of painless-lang with the exception of grok and dissect which will require additional work. The runtime fields xpack plugin still exists to hold the grok and dissect extensions needed, which depend on grok and dissect lib and we will address as a follow-up. Also, the qa tests and yaml tests are yet to be moved. Despite the need for additional work, runtime fields are fully functional and users should not be impacted by this change.
javanna
added a commit
that referenced
this pull request
Feb 22, 2021
This commit makes a start on moving runtime fields to server. The runtime field types are now built-in. The dynamic fields builder extension (needed to make dynamic:runtime work) is removed: further simplifications are needed but are left for a follow-up. It is still possible to plug in custom runtime field types through the same extension point that the xpack plugin used to use. The runtime fields script contexts are now also moved to server, and the corresponding whitelists are part of painless-lang with the exception of grok and dissect which will require additional work. The runtime fields xpack plugin still exists to hold the grok and dissect extensions needed, which depend on grok and dissect lib and we will address as a follow-up. Also, the qa tests and yaml tests are yet to be moved. Despite the need for additional work, runtime fields are fully functional and users should not be impacted by this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a start on moving runtime fields to server.
The runtime field types are now built-in. The dynamic fields builder extension (needed to make dynamic:runtime) work is removed: further simplifications are needed but are left for a follow-up. It is still possible to plug in custom runtime field types through the same extension point that the xpack plugin used to use.
The runtime fields script contexts are now also moved to server, and the corresponding whitelists are part of painless-lang with the exception of grok and dissect which will require additional work.
The runtime fields xpack plugin still exists to hold the grok and dissect extensions needed, which depend on grok and dissect lib and we will address as a follow-up. Also, the qa tests and yaml tests are yet to be moved.
Despite the need for additional work, runtime fields are fully functional and users should not be impacted by this change.