Fix long handling for version, if_seq_no and if_primary_term in SimulatePipelineRequest #69238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probakowski
added
>non-issue
:Data Management/Ingest Node
elasticmachine
added
the
Team:Data Management
|
Pinging @elastic/es-core-features (Team:Core/Features) |
|
@elasticmachine update branch |
probakowski
added a commit
to probakowski/elasticsearch
that referenced
this pull request
Feb 19, 2021
probakowski
added a commit
that referenced
this pull request
Feb 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #66197 we've lost ability to use longs for
version,if_seq_noandif_primary_term(only ints would work).That slipped through because 1 test went missing after refactoring in #50131.
This change fixes that with new
ConfigurationUtils.readOptionalStringOrLongPropertymethod and and brings back the test.Marking as
non-issueas the code with bug was not released yet.